Re: BUG #15044: materialized views incompatibility with logical replication in postgres 10

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Chad Trabant <chad(at)iris(dot)washington(dot)edu>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15044: materialized views incompatibility with logical replication in postgres 10
Date: 2018-02-24 03:14:43
Message-ID: bc5ac138-71a1-664e-49d1-b7bfa177a5be@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2/17/18 22:43, Peter Eisentraut wrote:
> On 2/5/18 10:33, Petr Jelinek wrote:
>>> Exactly.  The matview does not show up in pg_publication_tables but it's
>>> registered at some level.
>>
>> Indeed this is a bug. For normal publications we take care of this when
>> adding the relation to the publication but since ALL TABLES publications
>> don't check for membership we have to filter this directly in the output
>> plugin.
>
> I think the filtering in pgoutput ought to make use of
> is_publishable_class() in some way. That takes care of non-tables such
> as materialized views, but it also filters out the information_schema
> tables for example. Right now, if you insert something into one of the
> IS tables, it gets shipped over the wire but is then dropped by the
> apply because there is no pg_subscription_rel entry of the table. That
> doesn't quite have the user-visible effect as this bug, but it's bogus
> nonetheless.
>
> So I propose this alternative patch that covers all these cases.

Committed, and also added a new test in the master branch.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Meskes 2018-02-24 14:43:06 Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT
Previous Message David G. Johnston 2018-02-23 22:31:20 Re: BUG #15044: materialized views incompatibility with logical replication in postgres 10

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-02-24 03:29:34 Re: Online enabling of checksums
Previous Message Stephen Frost 2018-02-24 02:51:53 Re: Online enabling of checksums