| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent vs. git whitespace check |
| Date: | 2023-02-23 11:37:17 |
| Message-ID: | bbcb44e7-0f58-6d79-af5f-49f362832897@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-02-22 We 23:48, Tom Lane wrote:
> For my own taste, I really don't have any objection to // in isolation --
> the problem with it is just that we've got megabytes of code in the other
> style. I fear it'd look really ugly to have an intermixture of // and /*
> comment styles.
Maybe, I've seen some mixing elsewhere and it didn't make me shudder. I
agree that you probably wouldn't want to mix both styles for end of line
comments in a single function, although a rule like that would be hard
to enforce mechanically.
> Mass conversion of /* to // style would answer that,
> but would also create an impossible back-patching problem.
>
>
Yeah, I agree that's a complete non-starter.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2023-02-23 11:42:07 | Re: Support logical replication of DDLs |
| Previous Message | Peter Eisentraut | 2023-02-23 11:32:42 | Re: [PATCH] Add function to_oct |