Re: Support logical replication of DDLs

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Zheng Li <zhengli10(at)gmail(dot)com>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2023-02-23 11:42:07
Message-ID: CAFPTHDb=r=e+ztQr_krgusqjRWm-5PRCEJju0NRLKsjoVTM8fQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tue, Feb 7, 2023 at 11:05 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, 6 Feb 2023 at 17:02, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> I found few issues while testing:
> Issue 7: no owned sequence found
> Steps to reproduce:
> CREATE TABLE itest13 (a int);
> ALTER TABLE itest13 ADD COLUMN b int GENERATED BY DEFAULT AS IDENTITY;
>

I've fixed this issue. The reason for the failure was because, for
implicitly generated sequences,
the sequence relation is stored in coldef->identitysequence and has to
be fetched from there.
The fix is in patch-0002

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v73-0001-Infrastructure-to-support-DDL-deparsing.patch application/octet-stream 44.1 KB
v73-0005-DDL-messaging-infrastructure-for-DDL-replication.patch application/octet-stream 41.2 KB
v73-0004-Introduce-the-test_ddl_deparse_regress-test-modu.patch application/octet-stream 47.3 KB
v73-0002-Functions-to-deparse-Table-DDL-commands.patch application/octet-stream 131.3 KB
v73-0003-Support-DDL-deparse-of-the-rest-commands.patch application/octet-stream 201.2 KB
v73-0007-Document-DDL-replication-and-DDL-deparser.patch application/octet-stream 40.6 KB
v73-0006-Support-DDL-replication.patch application/octet-stream 213.0 KB
v73-0008-Allow-replicated-objects-to-have-the-same-owner-.patch application/octet-stream 58.9 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Stephen Frost 2023-02-23 16:47:27 Re: RLS without leakproof restrictions?
Previous Message Neethu P 2023-02-23 11:33:13 Re: Event Triggers unable to capture the DDL script executed

Browse pgsql-hackers by date

  From Date Subject
Next Message Melih Mutlu 2023-02-23 11:59:40 Re: Allow logical replication to copy tables in binary format
Previous Message Andrew Dunstan 2023-02-23 11:37:17 Re: pgindent vs. git whitespace check