Re: WIP: Covering + unique indexes.

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: WIP: Covering + unique indexes.
Date: 2018-04-10 16:03:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> * There is no pfree() within _bt_buildadd() for truncated tuples, even
> though that's a context where it's clearly not okay.

> * It might be a good idea to also pfree() the truncated tuple for most
> other _bt_buildadd() callers. Even though it's arguably okay in other
> cases, it seems worth being consistent about it (consistent with old
> nbtree code).
Seems, I don't see other calls to pfree after.

> * There should probably be some documentation around why it's okay
> that we call index_truncate_tuple() with an exclusive buffer lock held
> (during a page split). For example, there should probably be a comment
> on the VARATT_IS_EXTERNAL() situation.
I havn't objection to improve docs/comments.

> * Not sure that all calls to BTreeInnerTupleGetDownLink() are limited
> to inner tuples, which might be worth doing something about (perhaps
> just renaming the macro).
What is suspicious place for you opinion?

> I do not have the time to write a patch right away, but I should be
> able to post one in a few days. I want to avoid sending several small
> patches.
no problem, we can wait

Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2018-04-10 16:13:01 Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Previous Message Robert Haas 2018-04-10 15:59:40 Re: pgsql: Support partition pruning at execution time