| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
| Cc: | nathandbossart(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Using defines for protocol characters |
| Date: | 2023-08-09 15:19:20 |
| Message-ID: | b9b949be-dff6-e75f-c95b-71afc70cfa5d@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
1. As was discussed, these definitions should go into
src/include/libpq/pqcomm.h, not a new file.
2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest,
so it's easier to visually locate the start of the actual message name.
3. IMO, the names of the protocol messages in protocol.sgml are
canonical. Your patch appends "Request" and "Response" in cases where
that is not part of the actual name. Also, some messages are documented
to go both ways, so this separation doesn't make sense strictly
speaking. Please use the names as in protocol.sgml without augmenting them.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-08-09 15:26:40 | Re: Report planning memory in EXPLAIN ANALYZE |
| Previous Message | Ashutosh Bapat | 2023-08-09 15:11:58 | Re: Report planning memory in EXPLAIN ANALYZE |