| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, nathandbossart(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Using defines for protocol characters |
| Date: | 2023-08-09 16:27:37 |
| Message-ID: | CADK3HHJ2U_B0Rfdaj=0CMuTO1P-0NEmoAeYqU0XnkiHnqtg1dw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 9 Aug 2023 at 09:19, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> 1. As was discussed, these definitions should go into
> src/include/libpq/pqcomm.h, not a new file.
>
I'm ambivalent, this is very easy to do.
>
> 2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest,
> so it's easier to visually locate the start of the actual message name.
>
> 3. IMO, the names of the protocol messages in protocol.sgml are
> canonical. Your patch appends "Request" and "Response" in cases where
> that is not part of the actual name. Also, some messages are documented
> to go both ways, so this separation doesn't make sense strictly
> speaking. Please use the names as in protocol.sgml without augmenting
> them.
>
>
I've changed this a number of times. I do not mind changing it again, but
can we reach a consensus ?
Dave
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-08-09 16:31:35 | Re: Adding a pg_servername() function |
| Previous Message | Tomas Vondra | 2023-08-09 16:05:42 | Re: Use of additional index columns in rows filtering |