| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Error logging messages |
| Date: | 2022-04-14 14:32:33 |
| Message-ID: | b8097bc0-982a-a694-212d-3ac81d97e731@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.04.22 13:51, Daniel Gustafsson wrote:
> 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with a
> lowercase letter without punctuation.
I'm having some doubts about some of these changes, especially for
interactive features in psql, where the messages are often use a bit of
a different style. I don't think this kind of thing is an improvement,
for example:
- pg_log_error("You are currently not connected to a database.");
+ pg_log_error("you are currently not connected to a database");
If we want to be strict about it, we could change the message to
"not currently connected to a database"
But I do not think just chopping of the punctuation and lower-casing the
first letter of what is after all still a sentence would be an improvement.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-04-14 14:42:53 | Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403) |
| Previous Message | Euler Taveira | 2022-04-14 14:15:20 | Re: Support logical replication of DDLs |