| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Error logging messages |
| Date: | 2022-04-14 14:46:33 |
| Message-ID: | 22D11FF2-0F2A-4FA0-81B4-D318581CDF5F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 14 Apr 2022, at 16:32, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 13.04.22 13:51, Daniel Gustafsson wrote:
>> 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with a
>> lowercase letter without punctuation.
>
> I'm having some doubts about some of these changes, especially for interactive features in psql, where the messages are often use a bit of a different style. I don't think this kind of thing is an improvement, for example:
>
> - pg_log_error("You are currently not connected to a database.");
> + pg_log_error("you are currently not connected to a database");
That may also be a bit of Stockholm Syndrome since I prefer the latter error
message, but I see your point.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-04-14 15:02:33 | Re: BufferAlloc: don't take two simultaneous locks |
| Previous Message | Tom Lane | 2022-04-14 14:42:53 | Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403) |