| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Tips on committing |
| Date: | 2018-07-30 12:40:35 |
| Message-ID: | b745e9af-2142-3324-05d0-6797f0f427d3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 23/07/2018 05:58, Tom Lane wrote:
> 013f320dc reminds me of something I check for religiously: look for
> alternative output files for any regression test you're updating the
> output of.
>
> Actually updating said files, once you notice you need to, can be tricky
> in itself. Most of the time it works to just apply the same patch to the
> other variants as the delta you're observing for the output file that's
> relevant to your own platform. Or you may be able to change configuration
> so as to replicate the correct output for another alternative file. But
> sometimes you just have to guess (and then watch the buildfarm to see if
> you guessed right).
There is a recipe for doing this using the "merge" command here:
https://wiki.postgresql.org/wiki/Regression_test_authoring#Updating_an_existing_regression_test
YMMV
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-30 15:54:57 | pgsql: Doc: fix oversimplified example for CREATE POLICY. |
| Previous Message | Peter Eisentraut | 2018-07-30 11:51:46 | pgsql: Add ssl_library preset parameter |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-07-30 13:10:50 | Re: Usability fail with psql's \dp command |
| Previous Message | Julian Markwort | 2018-07-30 12:20:43 | Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full |