Re: backend/nodes cleanup: Move loop variables definitions into for statement

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: backend/nodes cleanup: Move loop variables definitions into for statement
Date: 2025-11-24 15:00:04
Message-ID: b45536be-b978-4038-8fd7-743c0f1285f4@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.11.25 11:32, Chao Li wrote:
> On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter(at)eisentraut(dot)org
> <mailto:peter(at)eisentraut(dot)org>> wrote:
>
>
>
> In a couple of cases, you are changing the type of the loop variable
> from Size to int.  I would not expect such a change in a patch of this
> nature.  If you have a reason to change it, please explain it (but I
> doubt the change is correct).
>
>
> That was a mistake. I fixed it in v3.

Still not correct in outDatum().

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2025-11-24 15:04:45 Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ​barriers
Previous Message Bertrand Drouvot 2025-11-24 14:54:01 Re: get rid of Pointer type, mostly