| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: backend/nodes cleanup: Move loop variables definitions into for statement |
| Date: | 2025-11-19 10:32:41 |
| Message-ID: | CAEoWx2kbpZm9R1eczt93QEqJ=brOuvX3GoP_=LowoQAKX-2sDw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
>
>
> In a couple of cases, you are changing the type of the loop variable
> from Size to int. I would not expect such a change in a patch of this
> nature. If you have a reason to change it, please explain it (but I
> doubt the change is correct).
>
>
That was a mistake. I fixed it in v3.
Best regards,
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-backend-nodes-cleanup-Move-loop-variables-definit.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-11-19 10:38:08 | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Previous Message | Japin Li | 2025-11-19 10:17:49 | Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement |