Re: PQinitSSL broken in some use casesf

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Chernow <ac(at)esilo(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQinitSSL broken in some use casesf
Date: 2009-02-10 17:05:50
Message-ID: b42b73150902100905x7fe00974sd2d01ee9a135ad05@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 10, 2009 at 12:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Tue, Feb 10, 2009 at 4:57 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>
>> PQinitSSL is *broken*. It's always been broken. Since it already
>> takes a parameter, I say add a special switch...the backwards
>> compatibility danger doesn't seem too bad.
>
> Add a switch to what? I get very nervous for our Windows users when
> people start talking about changing the libpq API (for those that
> don't know, Windows doesn't have DLL versioning like Unix - so any
> non-backwards compatible API change really needs a corresponding
> filename change to avoid pain and suffering).

PQinitSSL(SSL_ONLY) or something, where the constant is carefully
chosen to not be accidentally passed in by older libpq users.

merlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-02-10 17:08:48 Re: [COMMITTERS] pg-migrator - src: Add support for specifying port numbers.
Previous Message Andrew Chernow 2009-02-10 17:05:20 Re: PQinitSSL broken in some use casesf