Re: PQinitSSL broken in some use casesf

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Chernow <ac(at)esilo(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQinitSSL broken in some use casesf
Date: 2009-02-10 18:02:51
Message-ID: 4991C14B.6090601@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Merlin Moncure wrote:
> On Tue, Feb 10, 2009 at 12:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Tue, Feb 10, 2009 at 4:57 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>>
>>> PQinitSSL is *broken*. It's always been broken. Since it already
>>> takes a parameter, I say add a special switch...the backwards
>>> compatibility danger doesn't seem too bad.
>> Add a switch to what? I get very nervous for our Windows users when
>> people start talking about changing the libpq API (for those that
>> don't know, Windows doesn't have DLL versioning like Unix - so any
>> non-backwards compatible API change really needs a corresponding
>> filename change to avoid pain and suffering).
>
> PQinitSSL(SSL_ONLY) or something, where the constant is carefully
> chosen to not be accidentally passed in by older libpq users.

So how are you planinng to deal with it when your application passes
that to a version of libpq that doesn't support it?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2009-02-10 18:06:23 Re: PQinitSSL broken in some use casesf
Previous Message Bruce Momjian 2009-02-10 17:21:41 Re: Re: [COMMITTERS] pg-migrator - src: Add support for specifying port numbers.