| From: | Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: General purpose hashing func in pgbench |
| Date: | 2018-01-29 09:43:05 |
| Message-ID: | b2dd64bb-2d74-bde4-97df-fa1f57f079eb@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Fabien,
On 28.01.2018 11:10, Fabien COELHO wrote:
>
> Hello Ildar,
>
>> I did everything you mention here and attached a new version on the
>> patch.
>
> Patch applies, compiles, runs ok.
>
> Alas, I still have a few more very minor comments about the doc, sorry
> again:
No problem : )
>
> + <entry> <literal>default_seed</literal> </entry>
> + <entry>random seed used in hash functions by default</entry>
>
> s/random //: the seed may or may not be random.
>
> The "In some cases several distinct distributions..." paragraph is also
> just one line in the xml source file. It should be justified at about 80
> columns like others.
>
Fixed the doc, attached the patch. Thanks!
--
Ildar Musin
i(dot)musin(at)postgrespro(dot)ru
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench_hash_v11.patch | text/x-patch | 12.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-01-29 09:46:13 | Re: JIT compiling with LLVM v9.0 |
| Previous Message | Andres Freund | 2018-01-29 09:36:53 | Re: JIT compiling with LLVM v9.0 |