| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Thomas Reiss <thomas(dot)reiss(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Performance regression with PostgreSQL 11 and partitioning |
| Date: | 2018-06-27 07:56:14 |
| Message-ID: | b23dc88b-df41-ef07-22c5-12f77cf73b57@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/06/26 23:43, Alvaro Herrera wrote:
> On 2018-Jun-25, Tom Lane wrote:
>
>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>>> On 2018-Jun-18, David Rowley wrote:
>>>> I've attached a patch which cleans up my earlier version and moves the
>>>> setup of the append_rel_array into its own function instead of
>>>> sneaking code into setup_simple_rel_arrays(). I've also now updated
>>>> the comment above find_childrel_appendrelinfo(), which is now an
>>>> unused function.
>>
>>> I checked that this patch fixes the originally reported performance
>>> regression.
>>> Unless there are objections, I intend to push this patch tomorrow.
>>
>> If find_childrel_appendrelinfo is now unused, we should remove it.
>
> Agreed -- thanks for following up. Pushed that way.
I noticed that there is a typo in a comment, fixed as follows in the
attached patch.
/*
- * append_rel_list is the same length as the above arrays, and holds
+ * append_rel_array is the same length as the above arrays, and holds
* pointers to the corresponding AppendRelInfo entry indexed by
* child_relid, or NULL if none. The array itself is not allocated if
* append_rel_list is empty.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| append_rel_array-typo.patch | text/plain | 611 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2018-06-27 08:02:03 | Re: [HACKERS] WIP: Data at rest encryption |
| Previous Message | Amit Langote | 2018-06-27 07:30:04 | Re: postgresql_fdw doesn't handle defaults correctly |