Re: Performance regression with PostgreSQL 11 and partitioning

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Thomas Reiss <thomas(dot)reiss(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Performance regression with PostgreSQL 11 and partitioning
Date: 2018-06-27 19:43:46
Message-ID: 20180627194346.ntmuuczq7heacrhn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Jun-27, Amit Langote wrote:

> I noticed that there is a typo in a comment, fixed as follows in the
> attached patch.
>
> /*
> - * append_rel_list is the same length as the above arrays, and holds
> + * append_rel_array is the same length as the above arrays, and holds
> * pointers to the corresponding AppendRelInfo entry indexed by
> * child_relid, or NULL if none. The array itself is not allocated if
> * append_rel_list is empty.

Yikes. I looked for that kind of mistake *specifically* :-(
Thanks, pushed.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-06-27 19:49:56 Re: Allow cancelling VACUUM of nbtrees with corrupted right links
Previous Message Andres Freund 2018-06-27 19:18:45 Re: Allow cancelling VACUUM of nbtrees with corrupted right links