| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Stas Kelvich <stas(dot)kelvich(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: [HACKERS] CUBE seems a bit confused about ORDER BY |
| Date: | 2017-11-29 10:30:42 |
| Message-ID: | b180d211-2f28-a229-530d-a0e9bc287cb7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/2017 06:13 AM, Michael Paquier wrote:
> On Tue, Nov 21, 2017 at 7:07 AM, Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>> On Mon, Nov 20, 2017 at 1:59 PM, Alexander Korotkov
>> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>>>
>>> On Mon, Nov 20, 2017 at 4:09 AM, Tomas Vondra
>>> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>>>>
>>>> Seems fine to me, although perhaps it should be split into two parts.
>>>> One with the cube_coord_llur fixes, and then g_cube_distance changes
>>>> adding support for negative coordinates.
>>>
>>>
>>> Thank you for your feedback. I'll split this patch into two.
>>
>>
>> Please, find two patches attached.
>
> This got no reviews, so moved to next CF.
>
That is somewhat inaccurate, I believe. I won't claim it received enough
reviews, but it certainly received some. And splitting it into two does
not invalidate that, I guess.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2017-11-29 10:59:01 | Re: [HACKERS] CUBE seems a bit confused about ORDER BY |
| Previous Message | Ashutosh Bapat | 2017-11-29 10:00:17 | Re: [HACKERS] postgres_fdw super user checks |