Re: [HACKERS] CUBE seems a bit confused about ORDER BY

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Stas Kelvich <stas(dot)kelvich(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [HACKERS] CUBE seems a bit confused about ORDER BY
Date: 2017-11-29 10:59:01
Message-ID: CAPpHfdtd+UBuoYDPcWX7Qnj67hF-CCTwd++2BWviznoQ9gzQRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 29, 2017 at 1:30 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
wrote:

> On 11/29/2017 06:13 AM, Michael Paquier wrote:
> > On Tue, Nov 21, 2017 at 7:07 AM, Alexander Korotkov
> > <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> >> On Mon, Nov 20, 2017 at 1:59 PM, Alexander Korotkov
> >> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> >>>
> >>> On Mon, Nov 20, 2017 at 4:09 AM, Tomas Vondra
> >>> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
> >>>>
> >>>> Seems fine to me, although perhaps it should be split into two parts.
> >>>> One with the cube_coord_llur fixes, and then g_cube_distance changes
> >>>> adding support for negative coordinates.
> >>>
> >>>
> >>> Thank you for your feedback. I'll split this patch into two.
> >>
> >>
> >> Please, find two patches attached.
> >
> > This got no reviews, so moved to next CF.
> >
>
> That is somewhat inaccurate, I believe. I won't claim it received enough
> reviews, but it certainly received some. And splitting it into two does
> not invalidate that, I guess.

Sure, patch got some review. I've no objection against moving this to the
next commitfest though.
Since, these patches include bug fix, it's possible that someone will
commit it before next commitfest.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2017-11-29 11:32:30 Re: [HACKERS] CUBE seems a bit confused about ORDER BY
Previous Message Tomas Vondra 2017-11-29 10:30:42 Re: [HACKERS] CUBE seems a bit confused about ORDER BY