From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_recvlogical requires -d but not described on the documentation |
Date: | 2025-03-18 05:34:52 |
Message-ID: | b15ecf4f-e5af-4fbb-82c2-a425f453e0b2@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2025/03/12 14:59, David G. Johnston wrote:
> On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com <mailto:kuroda(dot)hayato(at)fujitsu(dot)com>> wrote:
>
>
> OK, so I will exclude the point in the thread. The patch I've posted contains all of fixes
> which is required.
>
>
> The patch fixes the synopsis and the mention of the default value. Only the later is required. I cannot figure out a policy that would alter the synopsis in the proposed manner. I’d suggest leaving it alone for now and tweak any of the option descriptions that may need clarification.
I agree that the synopsis doesn't need to be updated. Attached patch clarifies
the required options for each action in the documentation. Thought?
BTW, I'm curious why --dbname isn't required for the --drop-slot action. When I ran
pg_recvlogical --drop-slot without --dbname, I got the following error:
pg_recvlogical: error: could not establish database-specific replication connection
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
v2-0001-doc-Clarify-required-options-for-each-action-in-p.patch | text/plain | 3.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2025-03-18 05:46:09 | Re: Re: proposal: schema variables |
Previous Message | Masahiko Sawada | 2025-03-18 04:35:43 | Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus |