Re: buildfarm windows checks / tap tests on windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: buildfarm windows checks / tap tests on windows
Date: 2021-03-04 18:31:39
Message-ID: b04d7a8c-dc67-cd62-a93d-0dc27f57043e@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 3/4/21 12:56 PM, Andres Freund wrote:
> Hi,
>
> On 2021-03-04 11:10:19 -0500, Andrew Dunstan wrote:
>> Here's the patch.
> Awesome. Will you commit it?

Done

>
>
>> I didn't see a convenient way of handling the pg_recvlogical case, so
>> that's unchanged.
> Is the problem actually the kill_kill() itself, or just doing
> ->kill_kill() without a subsequent ->finish()?

Pretty sure it's the kill_kill that causes the awful crash Michael and I
have seen.

>
> But anyway, that seems like a less critical test...

right

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-03-04 19:01:13 Re: Increase value of OUTER_VAR
Previous Message Tom Lane 2021-03-04 18:11:19 Re: Increase value of OUTER_VAR