Re: Fix sequence membership command in PG19 release notes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, rh(at)vonng(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Fix sequence membership command in PG19 release notes
Date: 2026-10-27 21:47:25
Message-ID: auEb7WwTL58dnSU2@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> I just saw this change.
>
> Personally, I find all those "This is enabled" bullets in this Logical
> Replication section to be potentially misleading because SUBSCRIPTION
> "enabled" or "disabled" [1] is an entirely different and unrelated
> concept to the sequence support.
>
> IMO all those points might be better expressed like
>
> "This occurs during ....", or
> "This happens when ...."
> "This is achieved by ..." or
> etc.
>
> e.g. choose anything that avoids the word "enabled"

I adjusted two places where "enable" was not the right word; applied
patch attached.

For these two sentences that you mentioned:

* This is enabled with the ALL SEQUENCES clause.
* This is enabled with the REFRESH SEQUENCES clause.

I realize "enabled" could be an overused concept in this text, but using
something like:

This occurs during the ALL SEQUENCES clause.
This happens when the ALL SEQUENCES clause.
This is achieved by the ALL SEQUENCES clause.

seem much less clear than the existing text.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

Attachment Content-Type Size
REL_19_STABLE.diff text/x-diff 1.2 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Peter Smith 2026-10-27 22:30:12 Re: Fix sequence membership command in PG19 release notes
Previous Message PG Doc comments form 2026-10-27 20:56:24 postmaster.pid also contains shared memory key