| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, rh(at)vonng(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix sequence membership command in PG19 release notes |
| Date: | 2026-10-27 22:30:12 |
| Message-ID: | CAHut+PsXRZP4FScd2U6KFVv+zsEHCM-qR-xtu7wkRs4gsnn2kw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Wed, Oct 28, 2026 at 8:47 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> > I just saw this change.
> >
> > Personally, I find all those "This is enabled" bullets in this Logical
> > Replication section to be potentially misleading because SUBSCRIPTION
> > "enabled" or "disabled" [1] is an entirely different and unrelated
> > concept to the sequence support.
> >
> > IMO all those points might be better expressed like
> >
> > "This occurs during ....", or
> > "This happens when ...."
> > "This is achieved by ..." or
> > etc.
> >
> > e.g. choose anything that avoids the word "enabled"
>
> I adjusted two places where "enable" was not the right word; applied
> patch attached.
>
> For these two sentences that you mentioned:
>
> * This is enabled with the ALL SEQUENCES clause.
> * This is enabled with the REFRESH SEQUENCES clause.
>
> I realize "enabled" could be an overused concept in this text, but using
> something like:
>
> This occurs during the ALL SEQUENCES clause.
> This happens when the ALL SEQUENCES clause.
> This is achieved by the ALL SEQUENCES clause.
>
> seem much less clear than the existing text.
Oh, I didn't mean for those suggestions to be taken literally. The
ellipsis "..." and "etc." were supposed to mean -- choose any
replacement wording you want that avoids saying "enabled".
e.g.
This is done using the ALL SEQUENCES clause.
This is done using the REFRESH SEQUENCES clause.
(or whatever)
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-10-27 22:33:24 | Re: Fix sequence membership command in PG19 release notes |
| Previous Message | Bruce Momjian | 2026-10-27 21:47:25 | Re: Fix sequence membership command in PG19 release notes |