| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
| Cc: | Staroverov Ilja <i(dot)staroverov(at)ftdata(dot)ru>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters |
| Date: | 2026-10-26 23:28:52 |
| Message-ID: | at_iNExRxGKoaODg@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Oct 26, 2026 at 01:23:22PM -0500, Sami Imseih wrote:
> The column names in the SRF column definition list don't make those separate
> entries. I think JSON_TABLE column names should follow the same rule. Explicit
> PATH values are not included in the query ID, so I don't think omitting PATH
> should make the column name part of the query ID.
>
> So I think `JsonExpr.column_name` should be marked `query_jumble_ignore`
> instead of using a custom query jumble function.
Okay. How would this choice impact the PGSS outputs? Perhaps we
should first expand the tests with PATH keywords touching multiple
columns first? I was hesitant to do so while introducing the tests,
and only focused on the obviously-broken case with the ON ERROR/NULL
keywords handled as constants in the PGSS outputs.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-26 23:34:41 | Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction |
| Previous Message | Michael Paquier | 2026-10-26 23:23:17 | Re: pg_stat_statements stores WITH HOLD cursor query with literals |