Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters

Hi,

On Tue, Oct 27, 2026 at 08:28:52AM +0900, Michael Paquier wrote:
> On Mon, Oct 26, 2026 at 01:23:22PM -0500, Sami Imseih wrote:
>> So I think `JsonExpr.column_name` should be marked `query_jumble_ignore`
>> instead of using a custom query jumble function.

Agreed, thanks. This is consistent with the column definition lists
of functions in FROM, and it also merges a column without PATH with
the same column with an explicit PATH, which v5 kept apart.

> Okay. How would this choice impact the PGSS outputs? Perhaps we
> should first expand the tests with PATH keywords touching multiple
> columns first?

Attached is v6. 0001 adds tests with several columns, with and
without PATH, and with an explicit PATH equal to the one derived from
the column name. On master, the queries of this test block with the
same number of columns are all merged into a single entry, as the
column definitions are not part of the query ID.

0002 is the JSON_TABLE jumbling, with JsonExpr.column_name marked
query_jumble_ignore instead of the custom jumble function. For these
tests, its diff shows the same two entries as on master, with the
paths shown as parameter symbols. Compared to v5, the only change in
the expected output of the existing tests is that COLUMNS (a int) and
COLUMNS (b int) are now merged with the other queries with one column.

--
Ilya Staroverov