Re: Introduce contributor badges

Re: Jonathan S. Katz
> Thanks for working on this. I can provide some review on the current
> patches.

Thanks!

> While looking at the text edits, I saw that we're storing the badge binary
> in the database. This would be a first for .org; typically we store these in
> the repo, so we can leverage whatever cache/CDN mechanisms we have. While
> the code is pretty neat, IMV it'd be better to store it in our standard
> image directory.
>
> If there's a reason for this to be in the database, please let me know. I
> also know this is one of those things that we can ultimately change.

I've had file/repo storage in the first version because it was
simpler, but Magnus said we should use the pgeu image-in-database
code. I tend to agree that database is better, this is content that is
added frequently ("PGconf Wherever 20xx Speaker"), so automating the
process as much as possible makes sense.

The images themselves don't change (much), so varnish caching should
just work. One point that Magnus raised is if there are many images on
a page, some web browsers will open 80 concurrent connections and run
into some rate limit. If we reach that point, we need to create
sprites and serve the badges grid as one big image. (This is a UX
issue, not a bandwidth one.) But there is still time until that
happens, and for that, we can take the images from the database as
well.

> The rest of this looks OK.
>
> > v12-0001-Make-contributor-badges-discoverable.patch - what will
> > actually put the badges live
>
> I guess I missed why we're separating out Contributors + People, but if it's
> agreed upon I don't have too strong of an opinion. Otherwise just looking at
> it, I'm confused at the difference :)

We can definitely revisit the split after some time.

> Maybe we have to also retitle
> "Contributors" to "Recognized Contributors", i.e.
>
> - {'title': 'Contributors', 'link': '/community/contributors/'},
> + {'title': 'Recognized Contributors', 'link':
> '/community/contributors/'},

I had tried that, but rejected it because it got wrapped over two
lines in the sidebar, and none of the other menus have multi-line
entries. But maybe that's not a problem and we should just do it.
Done in the attached v13-0002.

> The rest LGTM.
>
> > v12-0001-Extend-badge-title-to-64-chars.patch - future database fix
>
> I don't think we need to be stingy on the characters here; I think the
> "default" we've used is 255; let's just be safe. (I'm also OK if we don't
> use TextField given these will typically be short).

Ack, will bump it in the staged DB commit v13-0003.

> > Assuming v12-0001-Contributor-copy-editing.patch is ok, would you
> > think that we can proceed with adding some badges now? My hope would
> > be to have at least "PostgreSQL 18 Contributor" live for Valencia.
> >
> > Timeline:
> > after ack: apply v12-0001-Contributor-copy-editing.patch
> > this week: create initial badges, add holders
> > have badges approved in moderation (they are still not visible)
> > shortly before the conference: apply v12-0001-Make-contributor-badges-discoverable.patch
> > later: apply v12-0001-Extend-badge-title-to-64-chars.patch
> Thanks,
>
> Jonathan

Given that we now have the review from Daniel and this what I read as
review-and-ack from Jonathan, I think we can proceed to add actual
badges. Tomorrow is 19rc1 release day, so I'd say Friday.

Christoph