| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-www(at)lists(dot)postgresql(dot)org, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Contributors <contributors(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce contributor badges |
| Date: | 2026-10-14 02:05:26 |
| Message-ID: | 329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Hi,
Thanks for working on this. I can provide some review on the current
patches.
On 10/12/26 9:28 AM, Christoph Berg wrote:
> What do you think about the open ends?
>
> Attachments:
> v12-0001-Contributor-copy-editing.patch - the stuff from this mail
While looking at the text edits, I saw that we're storing the badge
binary in the database. This would be a first for .org; typically we
store these in the repo, so we can leverage whatever cache/CDN
mechanisms we have. While the code is pretty neat, IMV it'd be better to
store it in our standard image directory.
If there's a reason for this to be in the database, please let me know.
I also know this is one of those things that we can ultimately change.
The rest of this looks OK.
> v12-0001-Make-contributor-badges-discoverable.patch - what will
> actually put the badges live
I guess I missed why we're separating out Contributors + People, but if
it's agreed upon I don't have too strong of an opinion. Otherwise just
looking at it, I'm confused at the difference :) Maybe we have to also
retitle "Contributors" to "Recognized Contributors", i.e.
- {'title': 'Contributors', 'link': '/community/contributors/'},
+ {'title': 'Recognized Contributors', 'link':
'/community/contributors/'},
(which also matches the new title of the page)
The rest LGTM.
> v12-0001-Extend-badge-title-to-64-chars.patch - future database fix
I don't think we need to be stingy on the characters here; I think the
"default" we've used is 255; let's just be safe. (I'm also OK if we
don't use TextField given these will typically be short).
> Assuming v12-0001-Contributor-copy-editing.patch is ok, would you
> think that we can proceed with adding some badges now? My hope would
> be to have at least "PostgreSQL 18 Contributor" live for Valencia.
>
> Timeline:
> after ack: apply v12-0001-Contributor-copy-editing.patch
> this week: create initial badges, add holders
> have badges approved in moderation (they are still not visible)
> shortly before the conference: apply v12-0001-Make-contributor-badges-discoverable.patch
> later: apply v12-0001-Extend-badge-title-to-64-chars.patch
Thanks,
Jonathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Loreta Ozolina | 2026-10-14 17:27:15 | Wiki editor request |
| Previous Message | Christoph Berg | 2026-10-12 13:28:39 | Re: Introduce contributor badges |