Re: injection_points: canceled or terminated waiters leak their wait slots

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: injection_points: canceled or terminated waiters leak their wait slots
Date: 2026-10-05 02:14:36
Message-ID: asMIDM-g3ZMzuKEE@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 02, 2026 at 10:44:20PM +0100, Zsolt Parragi wrote:
> I only disabled the two tests that already had failures on CI. After
> looking into it again I realized that temp-schema-cleanup could only
> fail with my hacked together linux repro, I can't reproduce it on
> windows. In wait_cleanup and slot_creation_error one session kills
> another session. In temp-schema-cleanup s1 kills itself. When the
> fatal happens the isolation tester is reading s1's socket, and
> receives the message properly, I can't make that fail without
> modifying the testcase.

Okay, let's only disable these two as a first step, then. For the
Makefiles, I have reused the same thing as pgcrypto, so as the
conditional test is stored in a variable before saving the ISOLATION
list. For meson, the lists have been moved outside the "tests". All
that felt slightly cleaner.

Now back to the main issue..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joao Detomini 2026-10-05 02:17:24 Re: doc: Document Linux cgroup memory limits
Previous Message Scott Ray 2026-10-05 01:46:33 Re: pg_xmin_horizon: a system view of everything pinning the xmin horizon