Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Grigorev Jurij <ju(dot)grigorev(at)ftdata(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry
Date: 2026-09-23 23:54:16
Message-ID: arRmqBEj9n0w3qCc@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 17, 2026 at 08:35:15AM +0000, Grigorev Jurij wrote:
> The two changes touch separate parts of pgstat_shmem.c, so the current
> HEAD patch should apply cleanly on top of the defensive change. I do
> not expect any conflicts, but I will rebase and resend it if needed.

I have put my head down on this patch. There was a lot of prose in
it, so I have spent time refining and making the whole shorter.
Another thing was some of the existing prose that got deleted, like
the comments at the top of "generation" and "refcount" when
initializing a new entry.

Cleaned up all that, and applied on HEAD.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2026-09-23 23:58:38 Re: Several issues with postgres_fdw stats import
Previous Message Amit Langote 2026-09-23 23:53:51 Re: PG19: two RI fast-path issues found while testing the batching revert