| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent in CI |
| Date: | 2026-09-22 16:33:11 |
| Message-ID: | arKtx76ROm1FhJIb@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 22, 2026 at 09:10:23AM +0200, Peter Eisentraut wrote:
> Previously discussed in [0]. People seemed to generally like the idea of
> running pgindent in CI but didn't want the job to fail outright if there
> were violations. My proposal here is to use a combination of GitHub Actions
> features [1] to create job annotations and step summaries to create some
> kind of warning output. I have attached an example screenshot.
+1. I think it'd be nice if the commitfest app showed some sort of
indicator, too.
FWIW I've been using my own custom pgindent for a couple of months that is
much faster, which might be nice if we're going to start running it in CI.
I just haven't gotten to posting the patches. The main ideas are 1)
running in parallel and 2) parsing typedefs.list once per run. That pretty
dramatically decreases the duration of a whole-tree indent.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-09-22 16:40:40 | Re: Catversion bumps during beta (was Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring) |
| Previous Message | Nathan Bossart | 2026-09-22 16:25:47 | Re: Teach pg_upgrade to deal with invalid databases |