| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: System views for versions reporting |
| Date: | 2026-09-22 14:28:14 |
| Message-ID: | arKP4SWL-9eQXZH0@ddolgov-thinkpadt14sgen1.rmtde.csb |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Thu, Nov 27, 2025 at 03:27:21PM +0100, Laurenz Albe wrote:
> Thanks, the patch looks good now.
>
> There is one tiny thing that I noticed only now, sorry:
>
> > --- a/src/backend/utils/misc/Makefile
> > +++ b/src/backend/utils/misc/Makefile
> > @@ -32,7 +32,8 @@ OBJS = \
> > stack_depth.o \
> > superuser.o \
> > timeout.o \
> > - tzparser.o
> > + tzparser.o \
> > + system_version.o
>
> That looks like an alphabetically sorted list too, so you should preserve
> that ordering.
>
> Anyway, I'll set this patch "ready for committer".
>
> I am not sure if this reduced form (no report on zstd, lz4, openssl,
> zlib etc.) is good enough for release, but I'll leave that decision to a committer.
Delayed thanks.
I just have noticed that the patch is not applied cleanly for some time,
here is the rebase.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-infrastructure-for-pg_system_versions-view.patch | text/plain | 11.5 KB |
| v7-0002-Add-core-versions-to-pg_system_versions.patch | text/plain | 8.3 KB |
| v7-0003-Add-JIT-provider-version-to-pg_system_versions.patch | text/plain | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Manu | 2026-09-22 14:45:48 | Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned foreign table |
| Previous Message | Jeevan Chalke | 2026-09-22 14:18:49 | Re: Add PRODUCT() aggregate function |