| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: System views for versions reporting |
| Date: | 2025-11-27 14:27:21 |
| Message-ID: | 1b327a0634514f39590703831c355aa64f894e65.camel@cybertec.at |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks, the patch looks good now.
There is one tiny thing that I noticed only now, sorry:
> --- a/src/backend/utils/misc/Makefile
> +++ b/src/backend/utils/misc/Makefile
> @@ -32,7 +32,8 @@ OBJS = \
> stack_depth.o \
> superuser.o \
> timeout.o \
> - tzparser.o
> + tzparser.o \
> + system_version.o
That looks like an alphabetically sorted list too, so you should preserve
that ordering.
Anyway, I'll set this patch "ready for committer".
I am not sure if this reduced form (no report on zstd, lz4, openssl,
zlib etc.) is good enough for release, but I'll leave that decision to a committer.
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernice Southey | 2025-11-27 14:31:10 | Re: Second RewriteQuery complains about first RewriteQuery in edge case |
| Previous Message | Bertrand Drouvot | 2025-11-27 14:17:23 | Re: Remove unused function parameters, part 1: contrib |