Re: Redundant headers in pg_stat_statements

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: m(dot)litsarev(at)postgrespro(dot)ru
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Redundant headers in pg_stat_statements
Date: 2026-09-14 12:24:22
Message-ID: aqfmptAg5MNTPD5F@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Sep-14, m(dot)litsarev(at)postgrespro(dot)ru wrote:

> Hi, hackers!
>
> I accidentially found that some headers in pg_stat_statements are redundant.
> A small patch with removed headers is attached.

Hi, I'm not sure that this achieves a whole lot -- these headers you
remove are indirectly included by some other header, so removing the
direct inclusions has no practical effect. See the inclusion graph for
that file here:
https://doxygen.postgresql.org/pg__stat__statements_8c.html

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
sources, so let's move on." (Nathaniel Smith)
https://mail.gnu.org/archive/html/monotone-devel/2007-01/msg00080.html

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2026-09-14 12:31:09 Re: [PATCH] Corruption Issue: Fix missing tts_tid in ExecForceStoreHeapTuple
Previous Message Burd, Greg 2026-09-14 12:16:58 Re: [PATCH] Corruption Issue: Fix missing tts_tid in ExecForceStoreHeapTuple