Re: [PATCH] Corruption Issue: Fix missing tts_tid in ExecForceStoreHeapTuple

On Mon, Sep 14, 2026 at 5:47 PM Burd, Greg <greg(at)burd(dot)me> wrote:
>
>
>
> > On Sep 14, 2026, at 8:10 AM, Virender Singla <virender(dot)cse(at)gmail(dot)com> wrote:
> >
> > Just a quick ping on this patch.
> > It appears the `tts_tid` assignment was inadvertently omitted from the
> > BufferHeapTupleTableSlot path in ExecForceStoreHeapTuple() when the
> > function was first introduced during the PG12 TupleTableSlot
> > refactoring [1].
>
> I ran into this myself and posted a patch [1] as well. I had not noticed your
> patch. Looks like both patches are essentially identical with different tests
> we could combine those into one and then possibly get the attention of a
> committer.
>
> > This was subsequently exposed when the GiST index scan reorder queue
> > was updated to route popped tuples through this same function [2]. The
> > relevant code hasn't changed since those commits.
> >
> > Thanks,
> > Virender
> > [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4da597edf1b
> > [2] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b8b94ea129f
>
> I agree, it's a bug/oversight that has lingered since v12 and should be fixed.

+1 this seems like and issue, we can compare this with
ExecStoreHeapTuple() which restore back the ctid so I think here it
seems like and oversight and attached patch seems to be doing right
thing.

--
Regards,
Dilip Kumar
Google