Re: Improve error handling in test modules: test_extensible, test_bitmapset

On Tue, Sep 08, 2026 at 12:16:36PM -0400, Greg Burd wrote:
> +1, and for test_bitmapset there's a concrete reason it's safe: every
> SQL wrapper decodes through the same PG_ARG_GETBITMAPSET ->
> text_to_bitmapset() path, 48 call sites, and there's no second decode
> route. So one function exercises the whole thing and the rest is
> duplicate coverage. I'd fold test_bms_copy('{VAR}') into
> test_bms_num_members() with the others.

FWIW, I'm also finding the addition of readBitmapset() in
test_bitmapset() kind of ugly to rely on. I'd rather keep to zero
the number of calls outside readfuncs.c, as this is historically a
function kept for compatibility with external code, more efficient
than nodeRead(). I was tempted to eliminate it from src/include/ a
couple of weeks ago, until Matthias' arguments convinced me otherwise
so they have been moved to readfuncs.h instead, as there is still some
external code using it.
--
Michael