| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: pg_stat_progress_cluster: do not default to CLUSTER |
| Date: | 2026-09-08 23:46:40 |
| Message-ID: | CAHGQGwH6rAd+fxWKRw=-i+SbzFtFRGDA5VBGJdMNNEsPO9YTqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 3, 2026 at 7:39 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> The attached patch fixes this to report NULL instead.
Thanks for the patch! It looks good to me. So, barring any objections,
I'll commit it.
BTW, as a separate issue, is the following also problematic?
WHEN command = 'REPACK' AND repack_index_relid = 0 THEN 'VACUUM FULL'
REPACK ... USING INDEX ... should basically be displayed as "CLUSTER".
But, if an index scan is not used (for example, when
enable_indexscan is disabled), repack_index_relid can be 0, causing
it to be displayed as "VACUUM FULL" unexpectedly. Thoughts?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-08 23:52:33 | Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry |
| Previous Message | Michael Paquier | 2026-09-08 23:35:03 | Re: Improve error handling in test modules: test_extensible, test_bitmapset |