Re: scary patch contest

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: scary patch contest
Date: 2026-08-31 16:47:09
Message-ID: apWwDQmTFNZi408M@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 31, 2026 at 06:44:42AM +0000, Bertrand Drouvot wrote:
> Hi,
>
> On Fri, Aug 28, 2026 at 08:48:51PM +0200, Daniel Gustafsson wrote:
> > > On 28 Aug 2026, at 20:31, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > >
> > > Looping back to Robert's list:
> > >
> > > On Tue, Aug 25, 2026 at 12:48:25PM -0400, Robert Haas wrote:
> > >> 1. RI fast-path FK checks / batching (2da86c1ef9b, b7b27eb41a5,
> > >> 2. REPACK / REPACK CONCURRENTLY (ac58465e061, 28d534e2ae0, Antonin
> > >> 3. Online data checksums (f19c0eccae9, Daniel Gustafsson and Magnus
> > >> 4. UPDATE/DELETE FOR PORTION OF (8e72d914c52, Paul Jungwirth c/b Peter
> > >> 5. SQL/PGQ property graphs (2f094e7ac69, Peter Eisentraut and Ashutosh
> > >> 6. postgres_fdw statistics import (28972b6fc3d, Corey Huinker and
> > >
> > > I see a lot of work happening on Online data checksums and REPACK. Is
> > > that a good thing, or a concern since we are a month away from release?
> >
> > I think that needs to evaluated against what, if anything, gets commmitted into
> > 19. The fact that work is happening is in itself good since that will benefit
> > the features in 20.
>
> +1.
>
> That said, the more I work on [0], the less I feel comfortable with the feature
> being part on 19.
>
> [0]: https://postgr.es/m/apUL3N4IE934qJ08%40bdtpg

This is referencing the online checksum change feature. I realize we
don't want to wait for features to do a release, but we are in a
situation where we might be reverting multiple big features, and we
don't even know if their removal will effect other changes that were
made assuming those feature existed. We know we will have to have
another beta to test after removing multiple features.

It feels we are in an unprecedented situation here.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-08-31 16:47:56 Re: another autovacuum scheduling thread
Previous Message Nathan Bossart 2026-08-31 16:28:13 Re: WAIT FOR command should do some query jumbling