| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, 邱宇航 <iamqyh(at)gmail(dot)com> |
| Subject: | Re: Thread-safe stringToNode() / pg_strtok() |
| Date: | 2026-08-24 03:22:17 |
| Message-ID: | aou4uvK2b8JAPFNj@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 23, 2026 at 06:38:58AM +0900, Michael Paquier wrote:
>> * nodes/extensible.h now includes nodes/readfuncs.h
>> I revised my opinion on this: I noticed my compiler complained
>> about the plain "struct ReadNodeContext *ctx" argument if I didn't put
>> a "struct ReadNodeContext;" declaration at the top level of the file,
>> which (when combined with relevant comments) would add more verbose
>> clutter than the alternative of including nodes/readfuncs.h.
89d091f602fa and 9673a0aa92f4 are now applied, for both changes.
Thanks for this work, Matthias.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-08-24 05:40:08 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Kevin Rocker | 2026-08-24 02:08:50 | Re: [PATCH] Fix vacuum_delay_point happening inside lock |