| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, 邱宇航 <iamqyh(at)gmail(dot)com> |
| Subject: | Re: Thread-safe stringToNode() / pg_strtok() |
| Date: | 2026-08-24 10:49:31 |
| Message-ID: | CAEze2WhRQq15AKUdosxDF2k=HNgdu9sF5jJcuQxVfKh4dkoDaA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 24 Aug 2026 at 05:22, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Aug 23, 2026 at 06:38:58AM +0900, Michael Paquier wrote:
> >> * nodes/extensible.h now includes nodes/readfuncs.h
> >> I revised my opinion on this: I noticed my compiler complained
> >> about the plain "struct ReadNodeContext *ctx" argument if I didn't put
> >> a "struct ReadNodeContext;" declaration at the top level of the file,
> >> which (when combined with relevant comments) would add more verbose
> >> clutter than the alternative of including nodes/readfuncs.h.
>
> 89d091f602fa and 9673a0aa92f4 are now applied, for both changes.
>
> Thanks for this work, Matthias.
Thanks for all the feedback and committing, Michael!
Kind regards,
Matthias van de Meent
Databricks (https://www.databricks.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-08-24 10:59:54 | Re: doc: Reformat SELECT queries using GRAPH_TABLE |
| Previous Message | Ashutosh Bapat | 2026-08-24 10:43:48 | Re: Fix GRAPH TABLE label and property error reporting |