| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Yilin Zhang <jiezhilove(at)126(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Date: | 2026-08-18 04:18:53 |
| Message-ID: | aoPdLUrm8D8+mvDN@bdtpg |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, Aug 17, 2026 at 04:06:09PM +0200, Daniel Gustafsson wrote:
> > On 17 Aug 2026, at 14:52, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> > I improved the tests a bit, while also adding the 32m shared buffers
>
> Thanks. I've squashed these patches and added PG_TEST_EXTRA gates as well as a
> note in the base backup documentation about how checksum verification is
> impacted in case enabling is in progress.
Thanks!
That looks good to me, just 1 nit comment:
=== 1
The test does not check that verification resumes while lastChecksumChangeRecPtr
is set. Just to be sure, did you skip that on purpose, or did you miss [1]?
[1]: https://postgr.es/m/aoMSMUUcNXJH4Djv%40bdtpg
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imran Zaheer | 2026-08-18 04:37:14 | Re: Failing assertion while taking a restartpoint during crash recovery |
| Previous Message | shveta malik | 2026-08-18 04:17:03 | Re: Proposal: Conflict log history table for Logical Replication |