| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Yilin Zhang <jiezhilove(at)126(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Date: | 2026-08-18 09:57:39 |
| Message-ID: | E392226B-8594-4873-93B5-8F8A54F50340@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 18 Aug 2026, at 06:18, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> The test does not check that verification resumes while lastChecksumChangeRecPtr
> is set. Just to be sure, did you skip that on purpose, or did you miss [1]?
Sorry, missed to mention that I skipped it on purpose since I don't really
foresee it providing much value. That being said, I have been wrong before so
I ended up adding one in the attached v7 anyway.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-basebackup-do-not-verify-checksums-on-pages-from-.patch | application/octet-stream | 34.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-08-18 10:00:09 | Re: fix more casting away of qualifiers |
| Previous Message | Bertrand Drouvot | 2026-08-18 09:55:36 | Re: pg_control_checkpoint(): add "data_checksum_version" (Pg19)? |