Re: GiST wal_consistency_checking issue

On Sat, Aug 15, 2026 at 07:31:01PM -0400, Peter Geoghegan wrote:
> The purpose of XLOG_GIST_DELETE relates in some way to old style
> VACUUM FULL. It's obviously useless now: there are 3 places that set
> F_TUPLES_DELETED, but nothing ever tests whether it is set in any GiST
> page's opaque area's flags field (barring pageinspect).
>
> Attached patch marks F_TUPLES_DELETED deprecated, removes all of its
> helper function-style macros, and removes all remaining callers of
> those macros.

batta tests wal_consistency_checking (maybe it's the only buildfarm
member doing so), and did not detect anything:
https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=batta&br=master

Your patch is not adding any tests, and I am pretty sure that recovery
test 027 would fail because standbys stop on an inconsistency.

Shouldn't the tests be expanded in some way, then? Your patch does
not do any of that. You could hide an extra expensive test script
under a conditional wal_consistency_checking, for example.
--
Michael