Re: Streamify more code paths

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Streamify more code paths
Date: 2026-08-04 12:08:25
Message-ID: anHWObuykWFpM6my@bdtpg
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Aug 04, 2026 at 08:41:35PM +0900, Michael Paquier wrote:
> On Tue, Aug 04, 2026 at 09:40:23AM +0300, Nazir Bilal Yavuz wrote:
> > On Mon, 3 Aug 2026 at 15:25, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> >> The simplest fix is to reorder a few lines of code - attached (with a
> >> test generated by Claude based on my instructions).
> >
> > I agree with you, fix LGTM.
>
> That seems sensible at first sight. I am not really convinced by the
> need of a test, even if useful to prove your point.

+1. Also I think that the test as it is, is missing a teardown to drop the
tablespace. What could work is a global teardown to drop the tablespace and move
the drop table in a per session teardown.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-08-04 12:09:09 Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support
Previous Message Michael Paquier 2026-08-04 11:41:35 Re: Streamify more code paths