| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Streamify more code paths |
| Date: | 2026-08-04 11:41:35 |
| Message-ID: | anHP76kHERin5G8H@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 04, 2026 at 09:40:23AM +0300, Nazir Bilal Yavuz wrote:
> On Mon, 3 Aug 2026 at 15:25, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
>> The simplest fix is to reorder a few lines of code - attached (with a
>> test generated by Claude based on my instructions).
>
> I agree with you, fix LGTM.
That seems sensible at first sight. I am not really convinced by the
need of a test, even if useful to prove your point.
> > But probably we should think broader to avoid such issues in the future.
>
> I am not sure how we can enforce this with a code check. Perhaps we
> can add a comment to the read_stream code, but I am not sure how
> effective that would be.
Not sure about this part. Let's fix the actual issue first. Will
double-check and address later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-08-04 12:08:25 | Re: Streamify more code paths |
| Previous Message | ZizhuanLiu X-MAN | 2026-08-04 11:40:07 | Re: Fix var_eq_const: sum selectivity of all matching MCV entries instead of stopping at first match |