Re: Increase repalloc_array() usage in buffile.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Increase repalloc_array() usage in buffile.c
Date: 2026-07-30 23:42:21
Message-ID: amvhXbTWVkPrsGoH@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 29, 2026 at 03:21:28PM -0500, Sami Imseih wrote:
> hmm, right. specifically 1b105f9472bdb bulk updated buffile.c. Only explanation
> I see is they were missed in a large update.

If you are interested in more work in this area, I think that we still
have a couple of holes in contrib/, and even more in the backend code.
Perhaps a LLM scan would help.

The reason why these holes exist is that the patch series of
1b105f9472bdb was quite large, so I have been focusing mainly on
making sure that all the suggested changes were right instead of
trying to fix all of them. The long term picture is that we should do
the switch to do more type enforcements, and that this work is
incremental.

Saying all that, the proposed patch makes sense, and this is
incremental work, so I am going to apply it.

Thanks for caring. :)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-07-30 23:57:52 Re: zic: fix PostgreSQL build failure on filesystems without hard link support
Previous Message Mark Wong 2026-07-30 22:54:10 Re: real/float example for testlibpq3