Re: zic: fix PostgreSQL build failure on filesystems without hard link support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: zic: fix PostgreSQL build failure on filesystems without hard link support
Date: 2026-07-30 23:57:52
Message-ID: 1711264.1785455872@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru> writes:
> PostgreSQL fails to build on filesystems that do not support hard links
> (e.g., exFAT, FAT32, some network filesystems). The build process stops
> with the following error during timezone data generation:
> Can't link <target> to <linkname>: Invalid argument

A question from the tzdb guys:

* Does the 'symlink' system call have the same problem on this MS-Windows platform? Should zic worry about them as well? (But if so, why didn't zic complain to your users about symlink?)

Also, it occurs to me to wonder if we're doing this to ourselves.
Specifically, it looks like src/port/win32error.c's _dosmaperr
will map ERROR_NOT_SUPPORTED to EINVAL, due to the lack of any
table entry for ERROR_NOT_SUPPORTED. Can you confirm which
underlying Windows error code is being returned?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Michael Paquier 2026-07-30 23:42:21 Re: Increase repalloc_array() usage in buffile.c