Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: DaeMyung Kang <charsyam(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb()
Date: 2026-07-27 00:53:32
Message-ID: amasDGQ1sQae-0lh@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 18, 2026 at 06:35:54AM +0900, Michael Paquier wrote:
> At this stage of the release cycle (aka feature freeze is in effect as
> of v19), I'd recommend that you add this patch to the next commit
> fest, so as this could be considered for v20, whose development should
> begin next July. See [1].
>
> [1]: https://commitfest.postgresql.org/59/

I had this one marked for some time, so I have looked at it again and
I think that you are right to rely on the fact that a partition OID
would match with a localreloid, saving from what could be an expensive
sequential scan on a hash table. Applied on HEAD as 0962f9e34439.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-07-27 01:32:43 Re: Fix missing FORMAT when deparsing JSON_ARRAY(query)
Previous Message Nico Williams 2026-07-26 23:53:20 Re: document the dangers of granting TRIGGER or REFERENCES