| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | DaeMyung Kang <charsyam(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb() |
| Date: | 2026-04-17 21:35:54 |
| Message-ID: | aeKnupQt-7iymhTb@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 18, 2026 at 02:44:50AM +0900, DaeMyung Kang wrote:
> LogicalRepPartMap is keyed by the partition's OID, which is assigned
> to entry->relmapentry.localreloid when the entry is populated in
> logicalrep_partition_open(). The invalidation callback therefore
> does not need to iterate over every entry to find the one matching
> the invalidated relation OID; a single hash_search(HASH_FIND) on
> reloid suffices.
At this stage of the release cycle (aka feature freeze is in effect as
of v19), I'd recommend that you add this patch to the next commit
fest, so as this could be considered for v20, whose development should
begin next July. See [1].
[1]: https://commitfest.postgresql.org/59/
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-04-17 21:41:42 | Re: Heads Up: cirrus-ci is shutting down June 1st |
| Previous Message | Michael Paquier | 2026-04-17 21:32:48 | Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY |