Re: pgbench bug candidate: negative "initial connection time"

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench bug candidate: negative "initial connection time"
Date: 2021-06-17 08:37:05
Message-ID: alpine.DEB.2.22.394.2106171028050.2693553@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Yugo-san,

> By the way, the issue of inital connection erros reported in this thread
> will be fixed by the patch attached in my previous post (a major part are
> written by you :-)

That does not, on its own, ensure that it is bug free:-)

> ). Is this acceptable for you?

I disagree on two counts:

First, thread[0] should not appear.

Second, currently the *only* function to change the client state is
advanceConnectionState, so it can be checked there and any bug is only
there. We had issues before when several functions where doing updates,
and it was a mess to understand what was going on. I really want that it
stays that way, so I disagree with setting the state to ABORTED from
threadRun. Moreover I do not see that it brings a feature, so ISTM that it
is not an actual issue not to do it?


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-06-17 08:54:35 Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Previous Message Greg Nancarrow 2021-06-17 08:22:24 Re: [HACKERS] logical decoding of two-phase transactions