Re: pgbench - refactor init functions with buffers

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - refactor init functions with buffers
Date: 2020-03-27 22:59:24
Message-ID: alpine.DEB.2.21.2003272354490.16227@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> Ok. I find it strange to mix PQExpBuffer & StringInfo in the same file.
> Agreed, but we'd rather use StringInfo going forward. However, I don't think
> that puts you on the hook for updating all the PQExpBuffer references.
> Unless you want to...

I cannot say that I "want" to fix something which already works the same
way, because it is against my coding principles.

However there may be some fun in writing a little script to replace one
with the other automatically. I counted nearly 3500 calls under src/bin.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-27 23:34:27 Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)
Previous Message David Rowley 2020-03-27 22:59:07 Re: Berserk Autovacuum (let's save next Mandrill)