| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - refactor init functions with buffers |
| Date: | 2020-03-27 22:26:32 |
| Message-ID: | 05af14b0-eadb-519d-6ed6-40996b554d54@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/27/20 6:13 PM, Fabien COELHO wrote:
>
> Hello David,
>
>>>> I'd prefer not to expand the use of pqexpbuffer in more places, and
>>>> instead rather see this use StringInfo, now that's also available to
>>>> frontend programs.
>>>
>>> Franckly, one or the other does not matter much to me.
>>
>> FWIW, I agree with Andres with regard to using StringInfo.
>
> Ok. I find it strange to mix PQExpBuffer & StringInfo in the same file.
Agreed, but we'd rather use StringInfo going forward. However, I don't
think that puts you on the hook for updating all the PQExpBuffer references.
Unless you want to...
>> Also, the changes to executeStatementExpect() and adding
>> executeStatement() do not seem to fit in with the purpose of this patch.
>
> Yep, that was in passing.
>
> Attached a v6 which uses StringInfo, and the small refactoring as a
> separate patch.
I think that's better, thanks.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-27 22:27:32 | Re: Conflict handling for COPY FROM |
| Previous Message | Fabien COELHO | 2020-03-27 22:25:58 | Re: pgbench - rework variable management |